Skip to content

No entity double fetch#72

Merged
dOrgJelli merged 7 commits intomasterfrom
no-entity-double-fetch
May 22, 2020
Merged

No entity double fetch#72
dOrgJelli merged 7 commits intomasterfrom
no-entity-double-fetch

Conversation

@cbrzn
Copy link
Copy Markdown
Member

@cbrzn cbrzn commented May 12, 2020

closes #53

@cbrzn
Copy link
Copy Markdown
Member Author

cbrzn commented May 12, 2020

Fun fact:
Now that we fix this, the tests were failing because we were doing:
Wait an entity was created -> wait for all entities to be created -> get the total of queried entities

That's because before, we needed to wait for a first entity to be queried, and then wait for the rest of entities, that way, the tests could wait for every entity to load and pass. Now we just wait for the loader component to disappear, because the load of the entities is faster :-)

@dOrgJelli dOrgJelli merged commit 79ae120 into master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Construct Component With Pre-Created Entity

2 participants